-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix kokoro config #662
Merged
Fix kokoro config #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowed values are standard and flex. Use them for the version. Always deploy app.yaml, so don't specify it.
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Jun 15, 2018
Codecov Report
@@ Coverage Diff @@
## master #662 +/- ##
=======================================
Coverage 48.52% 48.52%
=======================================
Files 1 1
Lines 68 68
=======================================
Hits 33 33
Misses 35 35 Continue to review full report at Codecov.
|
tbpg
approved these changes
Jun 15, 2018
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 16, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [4.4.0](googleapis/nodejs-asset@v4.3.0...v4.4.0) (2022-09-22) ### Features * Add client library support for AssetService v1 SavedQuery APIs ([#662](googleapis/nodejs-asset#662)) ([68c8ece](googleapis/nodejs-asset@68c8ece)) ### Bug Fixes * Preserve default values in x-goog-request-params header ([#658](googleapis/nodejs-asset#658)) ([e351ed1](googleapis/nodejs-asset@e351ed1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Shabirmean
pushed a commit
that referenced
this pull request
Feb 16, 2023
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/nodejs-dlp/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowed values are standard and flexible. Use them for the version string.
Always deploy app.yaml, so don't specify it.