Skip to content

Conversation

@michaelawyu
Copy link
Contributor

See #607 for more information.

See #607 for more information.
@michaelawyu michaelawyu requested a review from ace-n April 28, 2018 02:48
@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #608 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #608   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d9b39...c2bc6a7. Read the comment docs.

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming tests pass

@JustinBeckwith JustinBeckwith merged commit c67d955 into master May 4, 2018
@michaelawyu michaelawyu deleted the michaelawyu-patch-1 branch May 23, 2018 01:00
NimJay pushed a commit that referenced this pull request Nov 10, 2022
NimJay pushed a commit that referenced this pull request Nov 10, 2022
ace-n pushed a commit that referenced this pull request Nov 14, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
ace-n pushed a commit that referenced this pull request Nov 21, 2022
Co-authored-by: Benjamin E. Coe <bencoe@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants