Change to endpoints managed rollout #576

simonz130 · 2018-03-08T03:34:51Z

We introduce a new feature where we can specify in YAML that service configuration for Endpoints is going to be managed. This means that the service will pull latest deployed service configuration automatically, rather than requiring customer to specify specific version of service configuration.

New flag:
--rollout_strategy=managed
Previously the only way to specify a version was using the following flag:
--version=SERVICE_CONFIG_ID

wmwong · 2018-03-27T18:30:01Z

endpoints/getting-started-grpc/README.md

 ```
 $ gcloud endpoints services deploy api.pb api_config.yaml
 ...
-Service Configuration [SERVICE_CONFIG_ID] uploaded for service [SERVICE_NAME]


This was the only place where we define what SERVICE_NAME is. Without this, users may be confused about what SERVICE_NAME is.

I think we should leave this here, even if we don't end up using SERVICE_CONFIG_ID.

wmwong · 2018-03-27T18:30:33Z

endpoints/getting-started-grpc/README.md

@@ -44,11 +44,10 @@ $ protoc \

 1. In `api_config.yaml`, replace `MY_PROJECT_ID` and `SERVICE-ACCOUNT-ID` with your Project ID and your service account's email address respectively.

-1. Deploy your service's configuration to Endpoints. Take note of your service's config ID and name once the deployment completes.
+1. Deploy your service's configuration to Endpoints. 


We should still say:
Take note of your service's name once the deployment completes.

wmwong · 2018-03-27T18:32:15Z

endpoints/getting-started-grpc/README.md

@@ -107,7 +106,7 @@ $ gcloud components install kubectl
 $ gcloud container clusters get-credentials [YOUR_CLUSTER_NAME] --zone [YOUR_CLUSTER_ZONE]
 ```

-1. Edit the `container_engine.yaml` file, and replace `GCLOUD_PROJECT`, `SERVICE_NAME`, and `SERVICE_CONFIG` with your Project ID and your Endpoints service's name and config ID respectively.
+1. Edit the `container_engine.yaml` file, and replace `GCLOUD_PROJECT` and `SERVICE_NAME` with your Project ID and your Endpoints service's name.


Change "Project ID" -> "GCloud Project ID".
Change "Endpoints service's name" -> "service's name respectively".

This matches the instructions above.

codecov · 2018-04-03T22:02:35Z

Codecov Report

Merging #576 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #576   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           3      3           
=====================================
  Hits            3      3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c625e...8a570e3. Read the comment docs.

simonz130 · 2018-04-03T22:28:15Z

circleci timeout failure is due to functions emulator and has nothing to do with these changes.

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/nodejs-automl/compare/v2.5.1...v2.5.2) (2021-12-30) ### Bug Fixes * **deps:** update dependency csv to v6 ([#565](https://www.github.com/googleapis/nodejs-automl/issues/565)) ([7f1d947](https://www.github.com/googleapis/nodejs-automl/commit/7f1d9477cfa2d9697206dffabdfb92dfb80bc1d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09) ### Features * OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/nodejs-automl/compare/v2.5.1...v2.5.2) (2021-12-30) ### Bug Fixes * **deps:** update dependency csv to v6 ([#565](https://www.github.com/googleapis/nodejs-automl/issues/565)) ([7f1d947](https://www.github.com/googleapis/nodejs-automl/commit/7f1d9477cfa2d9697206dffabdfb92dfb80bc1d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ## [3.21.0](https://www.github.com/googleapis/nodejs-asset/compare/v3.20.0...v3.21.0) (2021-11-09) ### Features * OSConfig: add OS policy assignment rpcs ([#574](https://www.github.com/googleapis/nodejs-asset/issues/574)) ([ff9491d](https://www.github.com/googleapis/nodejs-asset/commit/ff9491d55bd527c451914b487ce08fed3068dbd8)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release \*beep\* \*boop\* --- ### [2.5.2](https://www.github.com/googleapis/nodejs-automl/compare/v2.5.1...v2.5.2) (2021-12-30) ### Bug Fixes * **deps:** update dependency csv to v6 ([#565](https://www.github.com/googleapis/nodejs-automl/issues/565)) ([7f1d947](https://www.github.com/googleapis/nodejs-automl/commit/7f1d9477cfa2d9697206dffabdfb92dfb80bc1d1)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[DO NOT MERGE]New deployment rollout

ca795ec

simonz130 requested review from wmwong and jmdobry March 8, 2018 03:34

simonz130 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 8, 2018

fixing readme to new rollout

c65da7f

wmwong suggested changes Mar 27, 2018

View reviewed changes

Addressing CR feedback for managed rollout

deb4d8c

Merge branch 'master' into newdeploymentrollout

8a570e3

simonz130 changed the title ~~[DO NOT MERGE] Change to endpoints managed rollout~~ Change to endpoints managed rollout Apr 3, 2018

simonz130 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2018

simonz130 merged commit 3cac032 into GoogleCloudPlatform:master Apr 3, 2018

simonz130 deleted the newdeploymentrollout branch April 3, 2018 22:30

This was referenced Dec 23, 2020

[Snyk] Security upgrade google-auth-library from 2.0.2 to 3.0.0 leejh3224/nodejs-docs-samples#287

Open

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#293

Open

This was referenced Sep 5, 2021

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#349

Open

[Snyk] Security upgrade google-auth-library from 2.0.2 to 3.0.0 leejh3224/nodejs-docs-samples#354

Open

This was referenced Jan 12, 2022

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#423

Open

[Snyk] Security upgrade google-auth-library from 2.0.2 to 3.0.0 leejh3224/nodejs-docs-samples#426

Open

This was referenced Feb 10, 2022

[Snyk] Security upgrade google-auth-library from 2.0.2 to 3.0.0 leejh3224/nodejs-docs-samples#456

Open

[Snyk] Fix for 1 vulnerabilities leejh3224/nodejs-docs-samples#464

Open

ace-n mentioned this pull request Nov 11, 2022

migrate code from googleapis/nodejs-automl #2841

Merged

ahrarmonsur mentioned this pull request Nov 16, 2022

migrate code from googleapis/nodejs-asset #2856

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change to endpoints managed rollout #576

Change to endpoints managed rollout #576

simonz130 commented Mar 8, 2018

wmwong Mar 27, 2018

wmwong Mar 27, 2018

wmwong Mar 27, 2018

codecov bot commented Apr 3, 2018 •

edited

Loading

simonz130 commented Apr 3, 2018

Change to endpoints managed rollout #576

Change to endpoints managed rollout #576

Conversation

simonz130 commented Mar 8, 2018

wmwong Mar 27, 2018

Choose a reason for hiding this comment

wmwong Mar 27, 2018

Choose a reason for hiding this comment

wmwong Mar 27, 2018

Choose a reason for hiding this comment

codecov bot commented Apr 3, 2018 • edited Loading

Codecov Report

simonz130 commented Apr 3, 2018

codecov bot commented Apr 3, 2018 •

edited

Loading