Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add a REST sample and test for AML AI #3809

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

feat: add a REST sample and test for AML AI #3809

wants to merge 5 commits into from

Conversation

irataxy
Copy link
Contributor

@irataxy irataxy commented Aug 28, 2024

Description

Fixes b: 355523386

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • [] This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@irataxy irataxy requested review from a team as code owners August 28, 2024 01:14
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Aug 28, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Aug 28, 2024
@irataxy irataxy changed the title docs: add a REST sample and test for AML AI feat: add a REST sample and test for AML AI Aug 28, 2024
iennae
iennae reviewed Aug 28, 2024
View reviewed changes
CODEOWNERS Show resolved Hide resolved
subfuzion
subfuzion requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few changes requested, but looks good overall. Thanks.

aml-ai/listLocations.js Outdated Show resolved Hide resolved
aml-ai/listLocations.js Outdated Show resolved Hide resolved
aml-ai/listLocations.js Outdated Show resolved Hide resolved
aml-ai/listLocations.js Outdated Show resolved Hide resolved
aml-ai/listLocations.js Show resolved Hide resolved
subfuzion
subfuzion approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@subfuzion subfuzion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Test fails because financialservices.googleapis.com isn't enabled (pending: cl/674939991).

aml-ai/listLocations.js

// node listLocations.js
main().catch(err => {
console.error(err);
Copy link
Member

@subfuzion subfuzion Sep 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this so mocha's reporter prints the reason for the failure. The current mocha test reporter filters out stdout but prints stderr, see logs using console.log() vs. console.error().

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cl/674939991 is merged, waiting on API enablement now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @irataxy The API was enabled (internal: cl/676595619). Looks like a few conflicts must be resolved to get this merged, however. Do you have bandwidth to follow up, or would you like to convert this to a draft or close it for now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Converted to draft for now

@irataxy irataxy marked this pull request as draft October 7, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae left review comments

@subfuzion subfuzion subfuzion approved these changes

Assignees
No one assigned
Labels
api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@irataxy @subfuzion @iennae @pattishin