Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(run): add Cloud Run + Filestore sample #3288
feat(run): add Cloud Run + Filestore sample #3288
Changes from 93 commits
1c6c01e
8a8a22b
a4150f2
30a721f
e2f513a
01daf73
41cc5fe
a340920
c27bb45
f74b6af
155877b
133a300
abb8703
f65b681
c943c48
b33d1b8
6b1b89c
e244cae
6d8737e
ae52f26
1539b75
8a15aed
6f2689b
a226df9
6224f8c
ac92606
0e963df
0af99cd
4af4979
963d85e
ad60445
709e007
69a73b6
476c028
b4b112c
668acab
4efdda0
eadcc86
4c82d59
10322c8
9b9b813
1be7a10
76748e8
e8eaa58
eebb278
667095d
b604c04
62c676c
0d3d1b6
926cd1f
51eec6b
890a349
c68f1c1
07b5329
93df837
acfe819
757c389
0657f82
605f059
5a403b7
df0e6ec
daaf07d
9eafb7c
18e9695
1b81ef0
d90097d
789d088
e901a4c
dc441f7
5b58bfe
b86fbc9
736d884
f187d8d
38deec6
8b46152
671d85e
577e217
a6e4fc9
4c40164
de5585f
a868e08
f993889
dabf84a
65be250
b7f67d9
8363f5d
637dd10
6c237fe
79d6047
286563c
2f0c3b5
572f490
85d5044
b434296
6ac4972
fde18ff
fe899cd
48f76ec
404e6f9
c63a493
bff9835
c7e312c
06e4f41
b9d0595
8336b7d
84c8dbf
3ac013a
8280e8a
0053c40
5470c1f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't add the "back" button to get back to the mount directory index.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sample can't add the back button because it's returning the actual file which is a plain-text .txt without HTML
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The canonical does this differently. Do you have a reason to break from the canonical?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Callbacks seem a bit outdated. A Node.js SME should weigh in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sofisl can you weigh in here? Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could use promises here! We could use the new fs promises module, like so, with a try-catch block.