Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fetch acl sample code for content warehouse #3287

Merged
merged 13 commits into from
Jun 24, 2023
Merged

feat: add fetch acl sample code for content warehouse #3287

merged 13 commits into from
Jun 24, 2023

Conversation

paulinawins
Copy link
Contributor

Description

Fixes issue

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones). content-warehouse API
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@paulinawins paulinawins requested review from a team as code owners June 21, 2023 11:19
@snippet-bot
Copy link

snippet-bot bot commented Jun 21, 2023

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jun 21, 2023
@paulinawins
Copy link
Contributor Author

Hi @telpirion or @holtskinner, could either of you review this PR (adds a nodeJS sample code for document warehouse)?

CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Collaborator

@kweinmeister kweinmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but minor changes requested. Thank you!

@kweinmeister
Copy link
Collaborator

Also if you can address these header check issues that would be great. The conventional commit check is not required, and not critical to me to change at this point (but other Node reviewers please feel free to assert this).

document-warehouse/.eslintrc.yml is missing a valid license header.
document-warehouse/test/.eslintrc.yml is missing a valid license header.
document-warehouse/test/fetch-acl.test.js is missing a valid copyright line.

@paulinawins paulinawins changed the title Fetch acl sample code for content warehouse feat: add fetch acl sample code for content warehouse Jun 21, 2023
Copy link
Contributor Author

@paulinawins paulinawins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed all of these requests

Copy link
Contributor Author

@paulinawins paulinawins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marking conversations as resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants