Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eventarc pubsub fix #2020

Merged
merged 4 commits into from
Oct 26, 2020
Merged

fix: eventarc pubsub fix #2020

merged 4 commits into from
Oct 26, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Oct 22, 2020

Fix Event unmarshalling data type.

Signed-off-by: Grant Timmerman <timmerman+devrel@google.com>
@grant grant requested a review from ace-n October 22, 2020 20:45
@grant grant requested a review from fhinkel as a code owner October 22, 2020 20:45
@grant grant self-assigned this Oct 22, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2020
@grant
Copy link
Contributor Author

grant commented Oct 22, 2020

Please merge when possible :)

@grant
Copy link
Contributor Author

grant commented Oct 22, 2020

#2020, nice :)

@ace-n
Copy link
Contributor

ace-n commented Oct 22, 2020

Failures are unrelated - @fhinkel can we merge?

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 23, 2020
@grant grant merged commit e4502b9 into master Oct 26, 2020
@grant grant deleted the grant_eventarc_pubsub_fix branch October 26, 2020 17:35
This was referenced Mar 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants