Skip to content

feat: change JS to satisfy Dataflow JS engine #1808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sofisl merged 5 commits into from
May 20, 2020
Merged

feat: change JS to satisfy Dataflow JS engine #1808

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9da5cda
feat: change JS to satisfy Dataflow JS engine
sofisl May 18, 2020
367e8e6
Merge branch 'master' into changeEngineforJSComposer
sofisl May 18, 2020
d91aacf
Merge branch 'master' into changeEngineforJSComposer
sofisl May 19, 2020
598e3f3
Merge branch 'master' into changeEngineforJSComposer
sofisl May 19, 2020
40eb5e0
Merge branch 'master' into changeEngineforJSComposer
fhinkel May 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions composer/composer_transform_csv_to_json.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/* eslint-disable func-style */
/* eslint-disable no-var */
// Copyright 2020 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand All @@ -19,8 +20,8 @@ module.exports = function main(
// [START composer_transform_csv_to_json]

function transformCSVtoJSON(line) {
const values = line.split(',');
const properties = [
var values = line.split(',');
var properties = [
'location',
'average_temperature',
'month',
Expand All @@ -30,13 +31,13 @@ module.exports = function main(
];
const weatherInCity = {};

for (let count = 0; count < values.length; count++) {
for (var count = 0; count < values.length; count++) {
if (values[count] !== 'null') {
weatherInCity[properties[count]] = values[count];
}
}

const jsonString = JSON.stringify(weatherInCity);
var jsonString = JSON.stringify(weatherInCity);
return jsonString;
}

Expand Down