Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove nodejs8 test for appengine analytics sample #1621

Merged
merged 3 commits into from
Mar 24, 2020

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Mar 10, 2020

See also CL 300189444.

The node.js 8 runtime has been deprecated in App Engine; in addition, some of the dependencies in this sample are no longer compatible with nodejs.8 (PR #1557)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 10, 2020
@michaelawyu
Copy link
Contributor Author

This PR is ready to merge as CL 300189444 has been submitted.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2020
@fhinkel fhinkel merged commit 9e2080f into master Mar 24, 2020
@fhinkel fhinkel deleted the appengine-analytics-node8-kokoro branch March 24, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants