Skip to content

Conversation

mesmacosta
Copy link
Contributor

@mesmacosta mesmacosta commented Oct 23, 2019

I would like to add samples for Data Catalog create_entry method, released on 1.3.0 @google-cloud/datacatalog version.

@mesmacosta mesmacosta requested a review from fhinkel as a code owner October 23, 2019 21:33
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 23, 2019
@mesmacosta mesmacosta changed the title Task/add create fileset entry [WIP]Task/add create fileset entry Oct 24, 2019
@mesmacosta
Copy link
Contributor Author

Changed to WIP, I will split the create entry and create entry group in two files.

@mesmacosta mesmacosta changed the title [WIP]Task/add create fileset entry Task/add create fileset entry Oct 24, 2019
@mesmacosta
Copy link
Contributor Author

The PR is ready now @fhinkel

// Construct the EntryGroup request to be sent by the client.
const entryGroupRequest = {
parent: datacatalog.locationPath(projectId, location),
entryGroupId: entryGroupId,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can use shorthand notation here:

const entryGroupRequest = {
    parent: datacatalog.locationPath(projectId, location),
    entryGroupId,
    entryGroup,
};

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, changed.

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@mesmacosta mesmacosta requested a review from fhinkel October 25, 2019 13:31
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Oct 25, 2019
@mesmacosta
Copy link
Contributor Author

The iot/manager test failing seem to be related to this change:
googleapis/nodejs-iot@68a1d6e

Method name changed, but test from sample code was not updated.
client.registryPath -> client.deviceRegistryPath

@fhinkel fhinkel mentioned this pull request Oct 25, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Oct 25, 2019

Yes, I can't merge this without manually diasbling CI. Let's wait a bit for the iot tests to get fixed. Sorry for the delay!

@mesmacosta
Copy link
Contributor Author

Yea it makes sense, I sent a PR with a proposed fix: #1528

@mesmacosta mesmacosta requested a review from tswast November 1, 2019 18:17
@tswast
Copy link
Contributor

tswast commented Nov 1, 2019

Thanks, LGTM. Once internal CL 277959432 merges, we can try again to run Kokoro.

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@mesmacosta
Copy link
Contributor Author

@tswast I solved the lint issue, but we need to enable Data Catalog API in the test environment:
"PERMISSION_DENIED: Google Cloud Data Catalog API has not been used in project ----------- before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/datacatalog.googleapis.com/overview?project=----------- then retry. If you enabled this API recently"

Can you help with that?

@fhinkel
Copy link
Contributor

fhinkel commented Nov 4, 2019

I just enabled the API. @mesmacosta do you have permission to add the kokoro label to start the tests again?

@mesmacosta
Copy link
Contributor Author

@fhinkel I don't

@fhinkel
Copy link
Contributor

fhinkel commented Nov 4, 2019

Just gave you access. If you add the kokoro-run label, the tests are being rerun again.

@mesmacosta mesmacosta added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 4, 2019
@mesmacosta
Copy link
Contributor Author

Thanks @fhinkel, waiting for @tswast to aprove the pending review now

@mesmacosta
Copy link
Contributor Author

@fhinkel can I go ahead and merge?

@mesmacosta mesmacosta merged commit 701f542 into GoogleCloudPlatform:master Nov 5, 2019
@mesmacosta mesmacosta deleted the task/add-create-fileset-entry branch November 5, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants