-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updating obsolete method for BigQuery #1482
Conversation
Thank you for providing nice tutorials. This is quickest proposal to make it work with latest client library. - Line 339: `table.import(...)` doesn't work and need to use `table.load(...)` instead. - Line 341: `job` doesn't have `promise()`
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@take4mats thanks for the fix! Could you sign the CLA? Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
N.B: We're planning to land a pretty big lint change soon - it might be easier to re-create this PR on top of it.
@fhinkel sorry for belated reaction... @googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@take4mats so sorry, as @ace-n mentioned, we landed a large change and have merge conflicts now. Do you want to resolve them? Thanks |
@fhinkel No, you can discard mine and prioritize the big change. Thank you. |
Replica of #1482 with newer changes to master
Thank you for providing nice tutorials.
This is quickest proposal to make it work with latest client library.
table.import(...)
doesn't work and need to usetable.load(...)
instead.job
doesn't havepromise()