Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating obsolete method for BigQuery #1482

Closed
wants to merge 1 commit into from

Conversation

take4mats
Copy link

Thank you for providing nice tutorials.
This is quickest proposal to make it work with latest client library.

  • Line 339: table.import(...) doesn't work and need to use table.load(...) instead.
  • Line 341: job doesn't have promise()

Thank you for providing nice tutorials.
This is quickest proposal to make it work with latest client library.
- Line 339: `table.import(...)` doesn't work and need to use `table.load(...)` instead.
- Line 341: `job` doesn't have `promise()`
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 16, 2019
@grant grant removed their request for review September 16, 2019 14:42
@fhinkel
Copy link
Contributor

fhinkel commented Sep 25, 2019

@take4mats thanks for the fix! Could you sign the CLA? Thank you

Copy link
Contributor

@ace-n ace-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.B: We're planning to land a pretty big lint change soon - it might be easier to re-create this PR on top of it.

@take4mats
Copy link
Author

@fhinkel sorry for belated reaction... @googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 26, 2019
@fhinkel
Copy link
Contributor

fhinkel commented Oct 10, 2019

@take4mats so sorry, as @ace-n mentioned, we landed a large change and have merge conflicts now. Do you want to resolve them? Thanks

@take4mats
Copy link
Author

@fhinkel No, you can discard mine and prioritize the big change. Thank you.

@ace-n ace-n closed this Oct 10, 2019
ace-n pushed a commit that referenced this pull request Oct 10, 2019
Replica of #1482 with newer changes to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants