Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS: add missing not-purely-GCF samples #1462

Merged
merged 2 commits into from
Aug 30, 2019
Merged

CODEOWNERS: add missing not-purely-GCF samples #1462

merged 2 commits into from
Aug 30, 2019

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Aug 29, 2019

RE datastore/functions - see #1460

@ericschmidtatwork please LGTM as well.

RE `datastore/functions` - see #1460
@ace-n ace-n requested a review from fhinkel as a code owner August 29, 2019 21:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 29, 2019
@ace-n ace-n merged commit aa65956 into master Aug 30, 2019
ace-n pushed a commit that referenced this pull request Aug 30, 2019
@ace-n
Copy link
Contributor Author

ace-n commented Aug 30, 2019

(Accidentally merged this 😕, will follow up internally to confirm there are no objections.)

@ghost
Copy link

ghost commented Sep 19, 2019

sorry for the delay, i don't check GitHub too often - looks good 👍

@fhinkel fhinkel deleted the gcf-codeowners branch December 3, 2019 00:17
This was referenced Sep 15, 2021
This was referenced Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants