Use native Buffer.from() - #1440
Merged
Merged
Conversation
fhinkel
requested review from
ace-n,
grant,
happyhuman and
michaelawyu
as code owners
August 2, 2019 14:07
googlebot
added
the
cla: yes
kokoro-team
removed
the
kokoro:run
safe-buffer is not needed in Node 8 anymore, we can safely use native Buffer.from(). See https://nodejs.org/fr/docs/guides/buffer-constructor-deprecation/
fhinkel
force-pushed
the
removeSafeBuffer
branch
from
August 2, 2019 14:14
17bf6ed to
7d56ac5
Compare
kokoro-team
removed
the
kokoro:run
JustinBeckwith
approved these changes
Aug 2, 2019
This was referenced Sep 15, 2021
This was referenced Sep 15, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
safe-bufferis not needed in Node 8 anymore, we can safely use nativeBuffer.from(). See
https://nodejs.org/fr/docs/guides/buffer-constructor-deprecation/