Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New samples for Cloud Functions docs #132

Merged
merged 23 commits into from
Jun 23, 2016
Merged

New samples for Cloud Functions docs #132

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
4a1c20d
Add HTTP Cloud Function.
jmdobry Jun 15, 2016
b981fe4
Add more GCF http samples.
jmdobry Jun 17, 2016
de7c2ba
Change string
jmdobry Jun 17, 2016
79ae033
Added promise sample.
jmdobry Jun 17, 2016
eec53f6
Add background functions tests.
jmdobry Jun 20, 2016
3b2c6fc
Added more GCF tests.
jmdobry Jun 20, 2016
85ec9ba
Fix readme and make test work in Node 0.12
jmdobry Jun 21, 2016
e27e128
Changed helloworld to camel case (#133)
jasonpolites Jun 21, 2016
2b57ec0
Changed helloworld to camel case (#134)
jasonpolites Jun 21, 2016
6ea5b95
Add BigQuery processing to SendGrid sample (still needs more tests).
jmdobry Jun 21, 2016
0493fa3
Add basic auth check.
jmdobry Jun 22, 2016
d278df7
Add fix for property names
jmdobry Jun 22, 2016
6a070cc
Make fixNames method recursive.
jmdobry Jun 22, 2016
94913d1
Changed helloworld to camel case (#136)
jasonpolites Jun 22, 2016
cf1f7ff
Add small helloGET sample.
jmdobry Jun 22, 2016
67f1810
Tweak some hello world samples.
jmdobry Jun 22, 2016
b1cfb26
Finish sendgrid unit tests.
jmdobry Jun 22, 2016
48f87cd
Add missing readme link.
jmdobry Jun 22, 2016
f69a769
Update comment.
jmdobry Jun 22, 2016
b2eb9d9
Make sure a response gets sent.
jmdobry Jun 23, 2016
d5a684e
Made requested fixes.
jmdobry Jun 23, 2016
7633d3d
Final fixes.
jmdobry Jun 23, 2016
78540e0
Couple fixes to fix test flakiness.
jmdobry Jun 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update comment.
  • Loading branch information
@jmdobry
jmdobry committed Jun 22, 2016
commit f69a769c0663e35df9f4767e879557511f04ab73
1 change: 1 addition & 0 deletions functions/background/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
*
* @param {Object} context Cloud Function context.
* @param {Object} data Request data, provided by a trigger.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that data expects a message property.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

* @param {string} data.message Message, provided by the trigger.
*/
exports.helloWorld = function helloWorld (context, data) {
if (data.message === undefined) {
Expand Down