[WIP / DO NOT MERGE] Make functions/ tests region-tag based #1292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
added 3 commits
May 16, 2019 17:34
ace-n
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
fhinkel
approved these changes
May 17, 2019
kokoro-team
removed
the
kokoro:run
ace-n
changed the title
fhinkel
added
the
do not merge
added 3 commits
May 17, 2019 18:18
Contributor
|
Are you still working on this PR or can we close it? |
Contributor
Author
|
The internal tools for this are being actively worked on. Let's plan on
keeping this open for the foreseeable future (at least 3-6 months from
now), unless we decide to merge it earlier.
…On Wed, Jul 17, 2019, 11:19 AM F. Hinkelmann ***@***.***> wrote:
Are you still working on this PR or can we close it?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1292?email_source=notifications&email_token=AARTZRLIRMYJG67D3ZEUIDTP75PEFA5CNFSM4HNRDG4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2GEVPY#issuecomment-512510655>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARTZRKPEKMNJLHAOAGQAXDP75PEFANCNFSM4HNRDG4A>
.
|
Contributor
Author
|
Closed in favor of #1499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until:
a) the other
functions/tests are covered, andb) I've finalized an MVP of said analytics on our (internal) backend
Moving
functionssamples to region-tag-based tests to make analytics easier.