Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: require node.js 8.13.0 and up (http/2) #1291

Merged
merged 2 commits into from
May 17, 2019
Merged

fix: require node.js 8.13.0 and up (http/2) #1291

merged 2 commits into from
May 17, 2019

Conversation

JustinBeckwith
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 16, 2019
@JustinBeckwith JustinBeckwith requested a review from ace-n May 17, 2019 21:42
@ace-n
Copy link
Contributor

ace-n commented May 17, 2019

@stew-r (GCF PM) has said we should keep the Node 6 function/ samples around. I asked @fhinkel to sync with him and see what next steps should be.

@fhinkel
Copy link
Contributor

fhinkel commented May 17, 2019

considering this is going from 8 to 8.13, I think we can land this. Removing Node 6 samples is a different discussion.

@JustinBeckwith JustinBeckwith merged commit 0056e70 into master May 17, 2019
@fhinkel fhinkel deleted the minver branch May 17, 2019 23:42
This was referenced Mar 16, 2020
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 17, 2020
Open
Open
Open
@pedroarapua pedroarapua mentioned this pull request Nov 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@ace-n ace-n Awaiting requested review from ace-n

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JustinBeckwith @ace-n @fhinkel @googlebot