Skip to content

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 7, 2019

Note: this does not include any additional Kokoro configs. @fhinkel happy to add one if you'd like.

(The other option that I think would be cleaner: we update the samples + add tests now, and fix Kokoro in another PR.)

@ace-n ace-n requested a review from fhinkel May 7, 2019 19:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 7, 2019
@fhinkel
Copy link
Contributor

fhinkel commented May 8, 2019

Fine with me to add Kokoro later

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't add linting to samples

@ace-n ace-n merged commit 6419d35 into master May 13, 2019
@ace-n ace-n deleted the update-sendgrid branch May 13, 2019 17:40
This was referenced Mar 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants