-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lint): prefer const
over var
#1224
Conversation
@fhinkel I didn't do anything to dialogflow, and the failure appears to be infra related:
|
Dialogflow PR hasn't been merged so it fails on all other PRs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. I'd prefer we wait with more of these changes until release tests pass tonight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change the fix command to npm run lint -- --fix? Doesn't really matter sind it's only one file.
No description provided.