Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate + fix skipped/flaky App Engine tests #339

Closed
ace-n opened this issue Apr 5, 2017 · 1 comment
Closed

Investigate + fix skipped/flaky App Engine tests #339

ace-n opened this issue Apr 5, 2017 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@ace-n
Copy link
Contributor

ace-n commented Apr 5, 2017

IIRC, we're currently skipping a bunch of App Engine system tests.

We should either fix the tests, or delete those samples.

May need input from @jmdobry on what to keep/delete.

@ace-n ace-n self-assigned this Apr 5, 2017
@ace-n ace-n closed this as completed Aug 21, 2017
@ace-n
Copy link
Contributor Author

ace-n commented Aug 21, 2017

These tests have been fixed. More tests will be added as part of #452 and future (similar) PRs.

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
ace-n pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 14, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 15, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 15, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 17, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ace-n pushed a commit that referenced this issue Nov 17, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
ahrarmonsur pushed a commit that referenced this issue Nov 17, 2022
Co-authored-by: Justin Beckwith <justin.beckwith@gmail.com>
pattishin pushed a commit that referenced this issue Nov 18, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
pattishin pushed a commit that referenced this issue Nov 22, 2022
* added create-featurestore-sample.js and create-featurestore-sample.test.js

* feat(samples): added createFeaturestore sample (#313)

* feat(samples): added remaining featurestore samples (#313)

* removed the extraneous files

* feat(samples): add entity type apis samples (#313)

* feat(samples): changed timeout for entity type apis samples (#313)

* feat(samples): update entity-type-samples.test.js (#313)

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: junkourata <102059808+junkourata@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants