-
Notifications
You must be signed in to change notification settings - Fork 2k
Closed
Labels
api: cloudassetIssues related to the Cloud Asset Inventory API.Issues related to the Cloud Asset Inventory API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.
Description
The language repo migration for googleapis/nodejs-asset
created the following PR:
#2856
The PR was blocked due to failing tests, which are all in one filetests/samples.test.js
. The advice from @grayside to unblock the migration PR was to:
- keep the tests in the migration
- remove the workflow for the
asset
samples - create an issue capturing the follow-on work
The language maintainers are to:
- refactor the tests into individual files corresponding to the sample
- generate the workflow for
asset/snippets
again
This is captured in this conversation.
Metadata
Metadata
Assignees
Labels
api: cloudassetIssues related to the Cloud Asset Inventory API.Issues related to the Cloud Asset Inventory API.priority: p2Moderately-important priority. Fix may not be included in next release.Moderately-important priority. Fix may not be included in next release.samplesIssues that are directly related to samples.Issues that are directly related to samples.type: cleanupAn internal cleanup or hygiene concern.An internal cleanup or hygiene concern.