Toggle bug in ProductCatalogService for demos

[MrTrustor]

Fixes #84

@ahmetb let me know what you think. I've used 150 microseconds because 200 slows the website down too much.

[ahmetb]

Thanks a lot, mostly LGTM.

I still wonder if we should do your original proposal which is USR1=turn on, USR2=turn off. If signaling turns out to be unreliable (kubectl exec is not reliable), then you can't reliably introduce the problem.

But I'll let you decide.

[MrTrustor]

I switched back to using USR2 to remove the bug. I don't have a strong opinion on this, but if you think that kubectl exec is not reliable (personally never had an issue with it), it's probably better like this.

[ahmetb]

We decided not to instrument Go services with debugger just yet because of the issues you pointed out. If the code above is good to you, I'll take this in.

[MrTrustor]

No, sorry not yet. I've slow on this one. I will try to finalise this by EOW. Sent from my phone. Sorry for the typos and the short emails!

…

On Wed, Nov 28, 2018, 01:06 Ahmet Alp Balkan ***@***.*** wrote: We decided not to instrument Go services with debugger just yet because of the issues you pointed out. If the code above is good to you, I'll take this in. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#85 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACu2Jih2B5q0vEz8lt8X3e5VqCZVe1Kfks5uzdOHgaJpZM4X1Bz0> .

[MrTrustor]

@ahmetb I finally took the time to come back to this. I changed my thinking on it.
The delay is now implemented as a broken "reload catalog" feature that actually reads and parse the full catalog on each request.
It introduces a noticeable delay in the frontend and does show up in Stackdriver Profiler.

It still is triggered and removed with USR1/USR2.

Let me know what you think.

[ahmetb]

If that gets you what you want, sounds good to me. Left a code comment.

[ahmetb]

Looks good. Thanks.