Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for failed docker image build #535

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Fix for failed docker image build #535

merged 1 commit into from
Apr 27, 2021

Conversation

sitaramkm
Copy link
Contributor

Signed-off-by: Sitaram IYER sitaramkm@gmail.com

Fixes #534 .

Change summary:

  • Fix building docker image for cartservice. PR 516 moved cartservice build artifacts to one level down to src directory breaking automated builds.
  • Special handling cart service with a if condition and appending src to build dir.

Remaining issues / concerns:
None afaik.

@sitaramkm
Fix building docker image for cartservice. PR 516 moved cartservice b…
886219d 
…uild artifacts to one level down to src directory breaking automated builds

Signed-off-by: Sitaram IYER <sitaramkm@gmail.com>
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 23, 2021
@sitaramkm sitaramkm changed the title Fix for failed docker image Fix for failed docker image build Apr 23, 2021
bourgeoisor
bourgeoisor approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally that this diff fixes the cartservice not building correctly and failing the image building process:

~ ./hack/make-docker-images.sh
. . .
. . .
Successfully built and pushed all images.

@bourgeoisor bourgeoisor merged commit b0160db into GoogleCloudPlatform:master Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bourgeoisor bourgeoisor bourgeoisor approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docker builds with make-docker-images.sh fails
3 participants
@sitaramkm @bourgeoisor @googlebot