Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update product name #527

Merged
merged 1 commit into from
Apr 2, 2021
Merged

update product name #527

merged 1 commit into from
Apr 2, 2021

Conversation

jantman
Copy link
Contributor

@jantman jantman commented Apr 2, 2021

I know this is... hilariously, embarrassingly pedantic... but I've been in a bootcamp this morning that uses this project as a demo app, and this is driving me bonkers...

The image that goes along with the "Vintage Camera Lens" product isn't of a camera lens, it's of a complete and functional camera... specifically, a 1930s-era 6x9cm folding Balda Juwella.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 2, 2021
@jantman
Copy link
Contributor Author

jantman commented Apr 2, 2021

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Apr 2, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Apr 2, 2021
@askmeegs
Copy link
Contributor

askmeegs commented Apr 2, 2021

Hi Jason, thanks for this correction, we appreciate it! :)

@askmeegs askmeegs merged commit 9b4e81e into GoogleCloudPlatform:master Apr 2, 2021
@jantman jantman deleted the patch-1 branch April 2, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants