Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cartservice - managed grpc #454

Merged
merged 11 commits into from
Dec 9, 2020
Merged

cartservice - managed grpc #454

merged 11 commits into from
Dec 9, 2020

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Dec 3, 2020 •
edited
Loading

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2020
@mathieu-benoit mathieu-benoit marked this pull request as draft December 3, 2020 03:31
@mathieu-benoit
Copy link
Contributor Author

For information at this stage, container image: 189MB --> 106MB.

@mathieu-benoit
Copy link
Contributor Author

For information at this stage, container image: 106MB --> 40.4MB.

@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Dec 4, 2020 •
edited
Loading

For information at this stage, container image: 40.4MB --> 50.3MB.

@github-actions
Copy link

github-actions bot commented Dec 4, 2020

🚲 PR staged at http://35.237.28.169

@github-actions
Copy link

github-actions bot commented Dec 5, 2020

🚲 PR staged at http://35.237.28.169

@github-actions
Copy link

github-actions bot commented Dec 6, 2020

🚲 PR staged at http://35.237.28.169

@github-actions
Copy link

github-actions bot commented Dec 6, 2020

🚲 PR staged at http://35.237.28.169

@mathieu-benoit mathieu-benoit marked this pull request as ready for review December 6, 2020 20:34
@mathieu-benoit mathieu-benoit changed the title [WIP] cartservice - managed grpc cartservice - managed grpc Dec 6, 2020
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@askmeegs
Copy link
Contributor

askmeegs commented Dec 8, 2020

This looks great overall, thanks for making these changes! Quick question, I noticed most of the generated proto files, such as src/cartservice/grpc_generated/Demo.cs, are removed - can you help me understand why the managed gRPC implementation makes these .pb files no longer needed?

Looking at this - https://docs.microsoft.com/en-us/aspnet/core/grpc/dotnet-grpc?view=aspnetcore-5.0
Seems like all it needs is the raw .proto file?

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

🚲 PR staged at http://35.237.28.169

@mathieu-benoit
Copy link
Contributor Author

mathieu-benoit commented Dec 9, 2020 •
edited
Loading

Good question @askmeegs, it's indeed a second approach available with .NET Core, if I recall correctly coming from this: https://grpc.io/blog/grpc-on-dotnetcore/#whats-new:

Unlike the existing C-Core based implementation (Grpc.Core), the new libraries (grpc-dotnet) make use of the existing networking primitives in the .NET Core Base Class Libraries (BCL). The diagram below highlights the difference between the existing Grpc.Core library and the new grpc-dotnet libraries.

And yes all it needs is the .proto file + <Protobuf Include="protos\Cart.proto" GrpcServices="Server" /> + services.AddGrpc(); + endpoints.MapGrpcService<CartService>();.

Let me know if you have any questions or need any complementary information.

@askmeegs
Copy link
Contributor

askmeegs commented Dec 9, 2020

Good question @askmeegs, it's indeed a second approach available with .NET Core, if I recall correctly coming from this: https://grpc.io/blog/grpc-on-dotnetcore/#whats-new:

Unlike the existing C-Core based implementation (Grpc.Core), the new libraries (grpc-dotnet) make use of the existing networking primitives in the .NET Core Base Class Libraries (BCL). The diagram below highlights the difference between the existing Grpc.Core library and the new grpc-dotnet libraries.

And yes all it needs is the .proto file + <Protobuf Include="protos\Cart.proto" GrpcServices="Server" /> + services.AddGrpc(); + endpoints.MapGrpcService<CartService>();.

Let me know if you have any questions or need any complementary information.

makes sense, thank you for clarifying!

@askmeegs askmeegs merged commit 4a60f61 into master Dec 9, 2020
@mathieu-benoit mathieu-benoit deleted the mathieu-benoit/cartservice-managed-grpc branch December 9, 2020 19:05
alanwest added a commit to newrelic-forks/microservices-demo that referenced this pull request Dec 9, 2020
@alanwest @mathieu-benoit
Update fork (#8)
5867c16 
* grpc-health-probe-0.3.5 (GoogleCloudPlatform#456)

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* grpc-health-probe-0.3.4

* GRPC_HEALTH_PROBE_VERSION=v0.3.5

* cartservice - managed grpc (GoogleCloudPlatform#454)

* managed grpc

* PublishSingleFile + PublishTrimmed

* ASPNETCORE_URLS

* AddHealthChecks

* Implement healthcheck

* /bin/grpc_health_probe

* -addr=localhost:7070

* unit tests

* GRPC_HEALTH_PROBE_VERSION=v0.3.5

* review unit test csproj

Co-authored-by: Mathieu Benoit <mathieu-benoit@hotmail.fr>
@elfinhe elfinhe mentioned this pull request Dec 10, 2020
Closed
@mathieu-benoit mathieu-benoit mentioned this pull request Dec 10, 2020
Merged
mlavacca pushed a commit to liqotech/microservices-demo that referenced this pull request Dec 16, 2020
@mathieu-benoit @mlavacca
cartservice - managed grpc (GoogleCloudPlatform#454)
b93983d 
* managed grpc

* PublishSingleFile + PublishTrimmed

* ASPNETCORE_URLS

* AddHealthChecks

* Implement healthcheck

* /bin/grpc_health_probe

* -addr=localhost:7070

* unit tests

* GRPC_HEALTH_PROBE_VERSION=v0.3.5

* review unit test csproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @askmeegs