Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET 5 for cartservice #445

Merged
merged 9 commits into from
Nov 23, 2020
Merged

.NET 5 for cartservice #445

merged 9 commits into from
Nov 23, 2020

Conversation

mathieu-benoit
Copy link
Contributor

@mathieu-benoit mathieu-benoit commented Nov 19, 2020 •
edited
Loading

Not related, but in addition:

  • alpine:3.8 --> alpine:3.12
  • grpc-health-probe 0.3.2 --> grpc-health-probe 0.3.4

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2020
@mathieu-benoit mathieu-benoit marked this pull request as draft November 19, 2020 19:52
@github-actions
Copy link

🚲 PR staged at http://35.196.199.111

@github-actions
Copy link

🚲 PR staged at http://35.196.199.111

@github-actions
Copy link

🚲 PR staged at http://35.196.199.111

@github-actions
Copy link

🚲 PR staged at http://35.196.199.111

@mathieu-benoit mathieu-benoit changed the title [WIP] .NET 5 for cartservice .NET 5 for cartservice Nov 20, 2020
@mathieu-benoit mathieu-benoit marked this pull request as ready for review November 20, 2020 00:16
@mathieu-benoit
Copy link
Contributor Author

Ready for your review, thanks!

@askmeegs askmeegs merged commit bcb2b21 into master Nov 23, 2020
@askmeegs askmeegs deleted the mathieu-benoit/cartservice-dotnet5 branch November 23, 2020 21:03
mlavacca pushed a commit to liqotech/microservices-demo that referenced this pull request Dec 16, 2020
@mathieu-benoit @mlavacca
.NET 5 for cartservice (GoogleCloudPlatform#445)
9bc1be1 
* mcr.microsoft.com/dotnet/sdk:5.0

* publishsinglefile+publishtrimmed: 189MB --> 124MB

* test without singlefile nor trim

* ACTIONS_ALLOW_UNSECURE_COMMANDS: true

* ACTIONS_ALLOW_UNSECURE_COMMANDS: true

* singlefile and trim: 189MB --> 124MB

* fix issue with singlefile and trim

* update packages versions

* alpine:3.12 + grpc-health-probe 0.3.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askmeegs askmeegs askmeegs approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mathieu-benoit @askmeegs