Replace --install-option with pip-level option #377
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
+1, this is needed. |
|
Can you please undo the diffs at the unrelated parts? |
|
@ahmetb - Done. |
|
please approve it , looks like this fix is the only way to run it at the moment and thank @prafullkotecha for it |
@ahmetb - ^^ |
zergundev
approved these changes
Aug 22, 2020
|
@zergundev - Can you please trigger the bot again? |
|
This is now fixed in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker build for
loadgeneratorservice fails due to this change in pip 20.2: pypa/pip#7309This change only makes that build complete successfully.