loadgenerator - Python 3.11
#1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚲 PR staged at http://35.223.27.27 |
|
Ready for your review, thanks! |
|
🚲 PR staged at http://35.223.27.27 |
NimJay
reviewed
Nov 29, 2022
| RUN apt-get -qq update \ | ||
| && apt-get install -y --no-install-recommends \ | ||
| g++ | ||
|
|
There was a problem hiding this comment.
Praise: Thanks for noticing that we don't need this for loadgenerator (because we're not using Cloud Profiler). And thanks for taking the initiative to delete it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
loadgenerator- Python 3.11Note: Same number of CVEs, 47 + size of the container image increased with +2.1MB.
Because we have issue with Cloud Profiler preventing both
emailserviceandrecommendationserviceto be upgraded to Python 3.11 (#1318), proposing to at least go ahead withloadgeneratorfor now.Also took the initiative to remove the unecessary/unused
g++installation and dependencies update in thebuilderstage.