Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing depends_on meta arguments to acceptance test config #9623

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Add missing depends_on meta arguments to acceptance test config #9623

merged 1 commit into from
Dec 12, 2023

Conversation

SarahFrench
Copy link
Contributor

Related to : hashicorp/terraform-provider-google#13609

Release Note Template for Downstream PRs (will be copied)

@SarahFrench SarahFrench requested a review from zli82016 December 12, 2023 11:09
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 12 insertions(+))
Terraform Beta: Diff ( 1 file changed, 12 insertions(+))

@SarahFrench SarahFrench mentioned this pull request Dec 12, 2023
Closed
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3290
Passed tests 2953
Skipped tests: 337
Affected tests: 0

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

zli82016
zli82016 approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing these.

@SarahFrench SarahFrench merged commit 1d1d8ed into main Dec 12, 2023
13 checks passed
This was referenced Dec 12, 2023
Merged
Merged
Merged
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@SarahFrench @kapreus
Add missing depends_on meta arguments to acceptance test config (Go…
15039c9 
…ogleCloudPlatform#9623)
@SarahFrench SarahFrench deleted the add-acctest-depends-on branch February 6, 2024 11:01
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@SarahFrench @balanaguharsha
Add missing depends_on meta arguments to acceptance test config (Go…
5ff3314 
…ogleCloudPlatform#9623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zli82016 zli82016 zli82016 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SarahFrench @modular-magician @zli82016