Remove use of google_kms_crypto_key_iam_binding resource in tests, to make tests stable in overnight testing

[SarahFrench]

This PR will help address test failures like:

• Failing test(s): TestAccComputeInstanceTemplate_sourceImageEncryptionKey (beta) hashicorp/terraform-provider-google#16687
• Failing test(s): TestAccCompute* ("Error 400: Cloud KMS error" permissions denied) hashicorp/terraform-provider-google#13609

In this PR I remove google_kms_crypto_key_iam_binding from tests that use shared crypto keys. I have also removed that resource from tests that provision their own crypto keys to improve signal-to-noise when we need to solve this same problem again in future.

This PR stops these tests affecting shared crypto keys:

• TestAccCloudFunctionsFunction_cmek (beta)
• TestAccComputeInstance_confidentialHyperDiskBootDisk (beta)

---

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 31 insertions(+), 26 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3279
Passed tests 2942
Skipped tests: 336
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudFunctionsFunction_cmek

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_cmek[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 31 insertions(+), 26 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3279
Passed tests 2942
Skipped tests: 336
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccCloudFunctionsFunction_cmek

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccCloudFunctionsFunction_cmek[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{red}{\textsf{Tests failed when rerunning REPLAYING mode:}}$
TestAccCloudFunctionsFunction_cmek[Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

---

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$
View the build log or the debug log for each test

[SarahFrench]

The TestAccCloudFunctionsFunction_cmek tests is experiencing the Requested interaction not found error; skipping test in VCR

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 2 files changed, 4 insertions(+), 8 deletions(-))
Terraform Beta: Diff ( 5 files changed, 33 insertions(+), 26 deletions(-))
TF OiCS: Diff ( 1 file changed, 2 insertions(+), 4 deletions(-))

[modular-magician]

Tests analytics

Total tests: 3279
Passed tests 2940
Skipped tests: 338
Affected tests: 1

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccSpannerInstanceIamPolicy

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSpannerInstanceIamPolicy[Debug log]

Rerun these tests in REPLAYING mode to catch issues

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$
View the build log or the debug log for each test

[SarahFrench]

Thanks!