Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add field traffic.tag and traffic.url to Cloud Run #5772

Merged
merged 6 commits into from
May 4, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions mmv1/products/cloudrun/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -297,13 +297,24 @@ objects:
required: true
description: |-
Percent specifies percent of the traffic to this Revision or Configuration.
- !ruby/object:Api::Type::String
name: tag
description: |-
Tag is optionally used to expose a dedicated url for referencing this target exclusively.
- !ruby/object:Api::Type::Boolean
name: latestRevision
description: |-
LatestRevision may be optionally provided to indicate that the latest ready
Revision of the Configuration should be used for this traffic target. When
provided LatestRevision must be true if RevisionName is empty; it must be
false when RevisionName is non-empty.
- !ruby/object:Api::Type::String
name: url
output: true
description: |-
URL displays the URL for accessing tagged traffic targets. URL is displayed in status,
and is disallowed on spec. URL must contain a scheme (e.g. http://) and a hostname,
but may not contain anything else (e.g. basic auth, url path, etc.)
- !ruby/object:Api::Type::NestedObject
name: template
description: |-
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ resource "google_cloud_run_service" "default" {
spec {
containers {
image = "gcr.io/cloudrun/hello"
args = ["arrgs"]
ports {
container_port = 8080
}
Expand All @@ -106,6 +105,7 @@ resource "google_cloud_run_service" "default" {
traffic {
percent = 100
latest_revision = true
tag = "magic-module"
}

lifecycle {
Expand Down