-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for manual builds, git source for webhook/pubsub triggered builds and filter field #5738
Add support for manual builds, git source for webhook/pubsub triggered builds and filter field #5738
Conversation
…sub_config, webhook_config trigger and manual mode
…sub_config, webhook_config trigger and manual mode
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @slevenick, please review this PR or find an appropriate assignee. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 698 insertions(+), 16 deletions(-)) |
/gcbrun |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 698 insertions(+), 16 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDatasourceGoogleServiceNetworkingPeeredDnsDomain_basic|TestAccApigeeEnvironmentIamBindingGenerated|TestAccApigeeEnvironmentIamMemberGenerated|TestAccApigeeEnvironmentIamPolicyGenerated|TestAccCloudBuildTrigger_cloudbuildTriggerPubsubConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerWebhookConfigExample|TestAccCloudBuildTrigger_cloudbuildTriggerManualExample|TestAccCloudbuildWorkerPool_basic|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=261062 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than that description change, I think everything else looks good! Thank you!
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 3 files changed, 696 insertions(+), 16 deletions(-)) |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceSqlDatabaseInstance_basic|TestAccBigqueryReservationAssignment_BasicHandWritten|TestAccCGCSnippet_sqlSqlserverInstanceAuthorizedNetworkExample|TestAccCloudBuildTrigger_cloudbuildTriggerBuildExample|TestAccCloudBuildTrigger_cloudbuildTriggerFilenameExample|TestAccCloudBuildTrigger_cloudbuildTriggerServiceAccountExample|TestAccCloudBuildTrigger_basic|TestAccCloudBuildTrigger_available_secrets_config|TestAccCloudBuildTrigger_disable|TestAccCloudBuildTrigger_fullStep|TestAccContainerCluster_withAuthenticatorGroupsConfig|TestAccEventarcTrigger_BasicHandWritten|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=264754 |
Tests failed during RECORDING mode: TestAccContainerCluster_withAuthenticatorGroupsConfig Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks so much!
Does this support the manual approval parameter for builds as well? I had assumed so, but it looks like this is relating to manually triggering builds, not manually approving builds? |
What do you mean by manually approving builds? Is there a particular field/method in the REST API you are looking to use? |
This supports creating builds to be manually invoked. This does not support
approval
…On Mon, Mar 14, 2022 at 5:41 PM Sam Levenick ***@***.***> wrote:
What do you mean by manually approving builds? Is there a particular
field/method in the REST API you are looking to use?
—
Reply to this email directly, view it on GitHub
<#5738 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABAPBA5RSWAV7GWCLSUPPE3U76W6XANCNFSM5PFKMZFQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
@slevenick @abhinavrau yeah, was looking for hashicorp/terraform-provider-google#9880 tho after I read the magic modules PR, realized this was the fix for something different. |
…d builds and filter field (GoogleCloudPlatform#5738) * add filter support for cloudbuild * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Fix description for field uri in sourceToBuild to be required
…d builds and filter field (GoogleCloudPlatform#5738) * add filter support for cloudbuild * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Fix description for field uri in sourceToBuild to be required
@slevenick @wyardley I have submitted a PR #5837 for hashicorp/terraform-provider-google#9880. Let me know how it works out. |
…d builds and filter field (GoogleCloudPlatform#5738) * add filter support for cloudbuild * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Add support for sourceToBuild and gitFileSource. Add examples for pubsub_config, webhook_config trigger and manual mode * Fix description for field uri in sourceToBuild to be required
Fixes hashicorp/terraform-provider-google#10779
Fixes hashicorp/terraform-provider-google#10434
Fixes hashicorp/terraform-provider-google#10387
Fixes hashicorp/terraform-provider-google#9755
Fixes hashicorp/terraform-provider-google#8374
Fixes hashicorp/terraform-provider-google#9189
Fixes hashicorp/terraform-provider-google#9883
Add support for REST fields
sourceToBuild
andgitFileSource
which adds support for manual builds as well as adds support for webhook and pubsub triggered builds with source code.Also added support for filter field that is used with webhook and pubsub triggered builds.
Also added examples for webhook, pubsub (with filter) and manual build.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)