Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using fixed IP in default subnetwork in service attachment example #5221

Merged
merged 2 commits into from
Sep 23, 2021

Conversation

rileykarson
Copy link
Member

This should help stop some VCR failures

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 2 deletions(-))
Terraform Beta: Diff ( 5 files changed, 4 insertions(+), 5 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 deletion(-))

@rileykarson rileykarson requested review from a team and slevenick and removed request for a team September 21, 2021 19:25
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 4 deletions(-))
Terraform Beta: Diff ( 5 files changed, 3 insertions(+), 6 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 deletion(-))

@rileykarson
Copy link
Member Author

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 4 deletions(-))
TF OiCS: Diff ( 1 file changed, 1 deletion(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207136

Copy link
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this causing problems? Multiple of these tests relying on the same IP that the API doesn't like?

@rileykarson
Copy link
Member Author

They're using the default network/subnetwork to avoid spending extra networks quota where it isn't needed, and if the tests run at the same time they pick the same fixed address. That didn't happen at first, which is why it didn't cause a problem! (Also, I think the tests were written at different times so I think they had no way of conflicting in VCR until both failed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants