-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using fixed IP in default subnetwork in service attachment example #5221
Stop using fixed IP in default subnetwork in service attachment example #5221
Conversation
/gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccComputeServiceAttachment_serviceAttachmentBasicExample|TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=207136 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this causing problems? Multiple of these tests relying on the same IP that the API doesn't like?
They're using the default network/subnetwork to avoid spending extra networks quota where it isn't needed, and if the tests run at the same time they pick the same fixed address. That didn't happen at first, which is why it didn't cause a problem! (Also, I think the tests were written at different times so I think they had no way of conflicting in VCR until both failed) |
This should help stop some VCR failures
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)