Inspec nested refactor #1368
Merged
Inspec nested refactor #1368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am a robot that works on MagicModules PRs! I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed. |
|
This also gets InSpec off of all the old style generation of files using the incorrect logic in type.rb for property_class and property_file methods. |
|
Does the InSpec downstream pass Rubocop? It seems like there's some super long line lengths. |
|
Yeah, rubocop is run during the generate step. The inspec-gcp rubocop file has very lenient line length restrictions |
rambleraptor
approved these changes
Feb 12, 2019
|
I am (still) a robot that works on MagicModules PRs! I just wanted to let you know that your changes (as of commit fdc57a7) have been included in your existing downstream PRs. |
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
modular-magician
force-pushed
the
inspec-nested-refactor
branch
from
10c31ac to
80a59c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor nested objects in InSpec to be namespaced by the entire path to get to that object. This makes sure that when a resource has two nested objects with the same name, but at different points within the object structure, they can have different formats.
For example: BigQuery Table schema can have a different nested object than externalDataConfiguration.schema
[all]
[terraform]
[terraform-beta]
[ansible]
[inspec]