Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inspec regional cluster #1295

Merged
merged 11 commits into from
Jan 30, 2019
Merged

Inspec regional cluster #1295

merged 11 commits into from
Jan 30, 2019

Conversation

slevenick
Copy link
Contributor

Add regional cluster support for InSpec

[all]

[terraform]

[terraform-beta]

[ansible]

[inspec]

@slevenick slevenick force-pushed the inspec-regional-cluster branch 3 times, most recently from 1d7e7bf to b3b1e5c Compare January 29, 2019 23:48
@modular-magician
Copy link
Collaborator

I am a robot that works on MagicModules PRs!

I built this PR into one or more PRs on other repositories, and when those are closed, this PR will also be merged and closed.
depends: modular-magician/ansible#179
depends: modular-magician/inspec-gcp#97

@rambleraptor
Copy link
Contributor

Can you add zone as an alias on Ansible? I can help show you how to do this

@slevenick slevenick force-pushed the inspec-regional-cluster branch 2 times, most recently from 1eff76d to 7c5b70d Compare January 30, 2019 01:02
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 1d5c3ac) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 3e308d9) have been included in your existing downstream PRs.

@slevenick slevenick force-pushed the inspec-regional-cluster branch from ea825cb to 360d402 Compare January 30, 2019 17:33
@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit dd4b6fb) have been included in your existing downstream PRs.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 2c4387b) have been included in your existing downstream PRs.

rambleraptor
rambleraptor approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@rambleraptor rambleraptor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ansible changes look good. lgtm.

@modular-magician
Copy link
Collaborator

I am (still) a robot that works on MagicModules PRs!

I just wanted to let you know that your changes (as of commit 6f58af4) have been included in your existing downstream PRs.

@modular-magician
Update tracked submodules -> HEAD on Wed Jan 30 21:31:25 UTC 2019
dca6d66 
Tracked submodules are build/terraform-beta build/terraform build/ansible build/inspec.
@modular-magician modular-magician merged commit 2d26e92 into master Jan 30, 2019
This was referenced Jan 31, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rambleraptor rambleraptor rambleraptor approved these changes

Assignees
No one assigned
Labels
ansible automerged cla: yes downstream-generated inspec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@slevenick @modular-magician @rambleraptor @googlebot