Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding resource organzation.source.finding #12839

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mithunkumar1507
Copy link
Member

@mithunkumar1507 mithunkumar1507 commented Jan 23, 2025

Complete the self-review checklist to help speed up the review process: https://googlecloudplatform.github.io/magic-modules/contribute/review-pr/
Template created for organization source findings
API reference https://cloud.google.com/security-command-center/docs/reference/rest/v2/organizations.sources.locations.findings/create

Template created for organization source findings

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`organizations.sources.findings`

@github-actions github-actions bot requested a review from NickElliot January 23, 2025 13:38
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link

@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@NickElliot
Copy link
Contributor

/gcbrun

Copy link
Contributor

@NickElliot NickElliot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you add a test for this resource? thanks!

The category of the finding (e.g., misconfiguration, vulnerability).
- name: 'severity'
type: String
required: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required: false

dont need any required: falses

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants