Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add MySQL 8.4 in google_sql_database_instance documentation #12610

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

translucens
Copy link
Contributor

@translucens translucens commented Dec 19, 2024

Fixes hashicorp/terraform-provider-google#20579

Release Note Template for Downstream PRs (will be copied)

sql: added MySQL 8.4 in `google_sql_database_instance` documentation

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 December 19, 2024 03:16
@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests service/sqladmin-cp and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 13 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 13 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 104
Passed tests: 88
Skipped tests: 15
Affected tests: 1

Click here to see the affected service packages
  • sql

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSqlDatabaseInstance_activationPolicy

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccSqlDatabaseInstance_activationPolicy [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that needs reviewer's approval to run presubmit tests labels Dec 19, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 13 insertions(+), 4 deletions(-))
google-beta provider: Diff ( 3 files changed, 13 insertions(+), 4 deletions(-))

@@ -239,7 +239,7 @@ The following arguments are supported:

* `database_version` - (Required) The MySQL, PostgreSQL or
SQL Server version to use. Supported values include `MYSQL_5_6`,
`MYSQL_5_7`, `MYSQL_8_0`, `POSTGRES_9_6`,`POSTGRES_10`, `POSTGRES_11`,
`MYSQL_5_7`, `MYSQL_8_0`, `MYSQL_8_4`, `POSTGRES_9_6`,`POSTGRES_10`, `POSTGRES_11`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MYSQL_8_4 is only added to the documentation. Does it need to be added to somewhere else to be supported?

Copy link

@sids-agravat sids-agravat Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MYSQL_8_4 is already supported. Ref b/383121405
I think this request name is confusing. It should be "Adding 8_4 version in documentation" instead as we already can create 8_4 instances through terraform

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR title

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 104
Passed tests: 89
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • sql

🟢 All tests passed!

View the build log

@translucens translucens changed the title add MySQL 8.4 support in google_sql_database_instance add MySQL 8.4 in google_sql_database_instance documentation Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support Cloud SQL for MySQL 8.4
4 participants