-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
container: unskipped VCR for TestAccContainerCluster_privateRegistry
#12217
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
741cf36
to
06f7843
Compare
TestAccContainerCluster_privateRegistry
TestAccContainerCluster_privateRegistry
TestAccContainerCluster_privateRegistry
TestAccContainerCluster_privateRegistry
Tests analyticsTotal tests: 215 Click here to see the affected service packages
Action takenFound 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
While working on #12216 (and #12135), I noticed that
TestAccContainerCluster_privateRegistry
appears to work in replaying mode:Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.