-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bigtable: fix failing test `TestAccBigtableTable_familyType #12189
bigtable: fix failing test `TestAccBigtableTable_familyType #12189
Conversation
Update regex to match the current error message Fixes hashicorp/terraform-provider-google#20001
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry!
Tests analyticsTotal tests: 49 Click here to see the affected service packages
🟢 All tests passed! View the build log |
The test passed in Teamcity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix.
Update regex to match the current error message
Fixes hashicorp/terraform-provider-google#20001
I decided to lose the leading / trailing
.*
, which I think is redundant. Looks like since it's re2, the literal.
doesn't need to be escaped.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.