Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigtable: fix failing test `TestAccBigtableTable_familyType #12189

Conversation

wyardley
Copy link
Contributor

@wyardley wyardley commented Oct 29, 2024

Update regex to match the current error message

Fixes hashicorp/terraform-provider-google#20001

I decided to lose the leading / trailing .*, which I think is redundant. Looks like since it's re2, the literal . doesn't need to be escaped.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from zli82016 October 29, 2024 21:18
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests service/bigtableadmin and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Oct 29, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

Copy link
Contributor

@ron-gal ron-gal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 49
Passed tests: 0
Skipped tests: 49
Affected tests: 0

Click here to see the affected service packages
  • bigtable

🟢 All tests passed!

View the build log

@zli82016
Copy link
Member

The test passed in Teamcity

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@zli82016 zli82016 merged commit c4be7b6 into GoogleCloudPlatform:main Oct 31, 2024
13 of 14 checks passed
@wyardley wyardley deleted the wyardley/issues_20001/bigtable_table_family_type_test branch October 31, 2024 17:06
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Nov 1, 2024
BBBmau pushed a commit to BBBmau/magic-modules that referenced this pull request Nov 5, 2024
akshat-jindal-nit pushed a commit to akshat-jindal-nit/magic-modules that referenced this pull request Nov 18, 2024
amanMahendroo pushed a commit to amanMahendroo/magic-modules that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccBigtableTable_familyType
4 participants