refactor: update resource manager tag references

[wyardley]

Part 2:

Update resource manager tag references in terraform code templates for generated tests (also some minor formatting changes)

• Update the code to use foo.id vs "tagKeys/${foo.name}" or "tagValues/${foo.name}"
• Update some project data source references to project.id vs projects/.....number
• Wrap map keys in parens where needed.

Followup to #12118

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 11 files changed, 118 insertions(+), 118 deletions(-))
google-beta provider: Diff ( 15 files changed, 142 insertions(+), 142 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 11 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1198
Passed tests: 1111
Skipped tests: 83
Affected tests: 4

Click here to see the affected service packages

• bigquery
• compute
• workstations

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain
• TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample

Get to know how VCR tests work

[modular-magician]

🔴 Tests failed during RECORDING mode:
TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample [Error message] [Debug log]
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[wyardley]

I’ll double check the changes, and try to run some of the failed ones locally - do the errors make it clear if the failures are due to this change?

[slevenick]

At least the BQ one seems to be
Error: Error creating Dataset: googleapi: Error 400: Invalid tagKey. Please use a valid tagKey., invalid

This one seems like a bad config, missing a quote or something: TestAccComputeRegionNetworkFirewallPolicyWithRules_computeRegionNetworkFirewallPolicyWithRulesFullExample

The others may be unrelated

[wyardley]

@slevenick I have a fix for the BQ one that I'm pushing up (works locally). I couldn't figure out how to run the generated test locally, but I found the errant quote, so updating that as well.

[wyardley]

hashicorp/terraform-provider-google#19885 << I think this is still not fixed and that may be the issue with TestAccComputeInstanceConfidentialInstanceConfigMain and probably also TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain.

[wyardley]

I don't know if it's the right fix, but opened #12149 on the off chance that it is.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 119 insertions(+), 120 deletions(-))
google-beta provider: Diff ( 16 files changed, 143 insertions(+), 144 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 11 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1198
Passed tests: 1112
Skipped tests: 83
Affected tests: 3

Click here to see the affected service packages

• bigquery
• compute
• workstations

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample
• TestAccComputeInstanceConfidentialInstanceConfigMain
• TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBigQueryDataset_bigqueryDatasetResourceTagsExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeInstanceConfidentialInstanceConfigMain [Error message] [Debug log]
TestAccComputeInstanceFromMachineImage_confidentialInstanceConfigMain [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[wyardley]

@slevenick can you try re-running those tests now that the test fix is merged?

[github-actions]

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 12 files changed, 119 insertions(+), 120 deletions(-))
google-beta provider: Diff ( 16 files changed, 143 insertions(+), 144 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 11 insertions(+), 12 deletions(-))

[modular-magician]

Tests analytics

Total tests: 1209
Passed tests: 1126
Skipped tests: 83
Affected tests: 0

Click here to see the affected service packages

• workstations
• bigquery
• compute

🟢 All tests passed!

View the build log