Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make reviewer assignment use main branch version of vacation data #11445

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Make reviewer assignment use main branch version of vacation data #11445

merged 8 commits into from
Sep 5, 2024

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Aug 14, 2024

Will fix hashicorp/terraform-provider-google#19032 (currently testing)

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge force-pushed the vacation-pr-review-blocking branch from 0472c5e to 394ea72 Compare August 14, 2024 20:05
@trodge trodge changed the title [TEST] reviewer assignment Make reviewer assignment use main branch version of vacation data Aug 14, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@trodge trodge marked this pull request as ready for review August 14, 2024 20:49
@trodge
Copy link
Contributor Author

trodge commented Aug 14, 2024

Closing to try re-opening

@trodge trodge closed this Aug 14, 2024
@trodge trodge reopened this Aug 14, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

trodge
trodge commented Aug 14, 2024
View reviewed changes
.ci/magician/github/membership.go Outdated
@@ -177,6 +91,10 @@ func IsCoreContributor(user string) bool {
}

func IsCoreReviewer(user string) bool {
// TESTING PURPOSES
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this didn't work to make the bot auto-assign a reviewer for this PR.

@trodge trodge requested review from a team and c2thorn and removed request for a team August 14, 2024 23:02
@trodge trodge mentioned this pull request Aug 21, 2024
Merged
@github-actions GitHub Actions
Copy link

This PR is approved and has been waiting for merge for 1 week. Is it ready to merge? Use the label disable-review-reminders to disable these notifications.

@trodge trodge force-pushed the vacation-pr-review-blocking branch from 9c961a5 to fa47374 Compare August 22, 2024 15:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@c2thorn c2thorn self-requested a review August 22, 2024 16:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@github-actions GitHub Actions
Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

c2thorn
c2thorn reviewed Aug 28, 2024
View reviewed changes
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review? Should I be the reviewer on it?

@trodge trodge requested a review from shuyama1 September 3, 2024 16:51
@trodge
Copy link
Contributor Author

trodge commented Sep 3, 2024

Is this ready for review? Should I be the reviewer on it?

It should be ready, but I'm still not sure how to test if it actually works as intended. See #11445 (comment)

Added Shuya in case we're still being cautious around CI changes.

shuyama1
shuyama1 reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Is there a way to test the changes before merging?

.github/workflows/request-reviewer.yml Outdated Show resolved Hide resolved
@trodge
Copy link
Contributor Author

trodge commented Sep 5, 2024

Mostly LGTM. Is there a way to test the changes before merging?

I'm testing it in my fork and finding that it breaks the workflow. Going to try a few more variations of the sparse checkout.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

shuyama1
shuyama1 approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for testing it!

@trodge trodge merged commit 60228fb into GoogleCloudPlatform:main Sep 5, 2024
8 of 10 checks passed
@trodge trodge deleted the vacation-pr-review-blocking branch September 5, 2024 19:13
This was referenced Sep 5, 2024
Merged
Merged
Merged
entertvl pushed a commit to entertvl/magic-modules that referenced this pull request Sep 9, 2024
@trodge @entertvl
Make reviewer assignment always use main branch (GoogleCloudPlatform#…
2196561 
…11445)
iyabchen pushed a commit to iyabchen/magic-modules that referenced this pull request Sep 14, 2024
@trodge @iyabchen
Make reviewer assignment always use main branch (GoogleCloudPlatform#…
85d76c1 
…11445)
abd-goog pushed a commit to abd-goog/magic-modules that referenced this pull request Sep 23, 2024
@trodge @abd-goog
Make reviewer assignment always use main branch (GoogleCloudPlatform#…
4f4f8c1 
…11445)
niharika-98 pushed a commit to niharika-98/magic-modules that referenced this pull request Oct 7, 2024
@trodge @niharika-98
Make reviewer assignment always use main branch (GoogleCloudPlatform#…
5eb93ce 
…11445)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c2thorn c2thorn c2thorn approved these changes

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with PR review blocking via .ci/magician/github/membership.go
4 participants
@trodge @modular-magician @c2thorn @shuyama1