Skip to content

[prometheus-to-sd] Add quantiles to summary type #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AttwellBrian
Copy link

@AttwellBrian AttwellBrian commented Mar 1, 2019

As discussed in #196, summary quantiles cannot be aggregated well. However, they are still useful and frequently used by Prometheus exporters. In order to allow stackdriver to be more of a drop in replacement for prom, this diff adds support for summary quantiles

Each quantile acts like a seperate label value. For the gauge.

Test Plan
Modified translater_test.go. Temporarily added the following to the Dockerfile. Then ran the Dockerfile.

RUN file="$(CGO_ENABLED=0 GOOS=linux go test ./translator/)"; echo $file

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Mar 1, 2019
},
MetricKind: "GAUGE",
Points: []*v3.Point{
// Like all gauges the translater assumes it is an integer, unfortunately :(
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a seperate issue that I'll look into in a separate diff.

I've seen this cause some frustrating issues before, outside of summary metric types.

@AttwellBrian
Copy link
Author

verify-gofmt.sh returns no problems on my machine. So I'm not certain what to do here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants