Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Billing Budgets Budget resource mocks #2981

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Billing Budgets Budget resource mocks #2981

wants to merge 1 commit into from

Conversation

barney-s
Copy link
Collaborator

@barney-s barney-s commented Oct 22, 2024 •
edited
Loading

Change description

Billing Budgets Budget resource mocks

Tests you have done

E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock go test -test.count=1 -timeout 3600s -v ./tests/e2e -run TestAllInSeries/fixtures/budgets 2>&1 | tee log

❯ cat log
=== RUN   TestAllInSeries
=== RUN   TestAllInSeries/fixtures
=== NAME  TestAllInSeries
    unified_test.go:116: shutting down manager
--- PASS: TestAllInSeries (0.26s)
    --- PASS: TestAllInSeries/fixtures (0.25s)
testing: warning: no tests to run
PASS
ok      github.com/GoogleCloudPlatform/k8s-config-connector/tests/e2e   1.198s [no tests to run]

@barney-s barney-s force-pushed the bbb branch 2 times, most recently from 6c25666 to 9dee85b Compare October 23, 2024 14:30
@barney-s barney-s requested a review from acpana October 23, 2024 14:40
@barney-s
Copy link
Collaborator Author

/assign @yuwenma @justinsb

@barney-s
Billing Budgets Budget resource mocks
023a63a 
- Following instructions at: https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/mockgcp/README.md
- Ran make gen-proto
- E2E_KUBE_TARGET=envtest RUN_E2E=1 E2E_GCP_TARGET=mock go test -test.count=1 -timeout 3600s -v ./tests/e2e  ..
@google-oss-prow Google OSS Prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from justinsb. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acpana acpana Awaiting requested review from acpana

At least 1 approving review is required to merge this pull request.

Assignees

@justinsb justinsb

@yuwenma yuwenma

Labels
do-not-merge/work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@barney-s @justinsb @yuwenma