Fix TCP Route test #183
Fix TCP Route test #183
Conversation
|
/cc @kl52752 /assign @bowei |
|
@AwesomePatrol: GitHub didn't allow me to request PR reviews from the following users: akwi-github. Note that only GoogleCloudPlatform members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
AwesomePatrol
force-pushed
the
fix-tcproute-test
branch
from
92b7e81 to
99ace2f
Compare
|
/lgtm |
AwesomePatrol
force-pushed
the
fix-tcproute-test
branch
from
99ace2f to
293ef8e
Compare
AwesomePatrol
force-pushed
the
fix-tcproute-test
branch
from
293ef8e to
cb00cac
Compare
Previously, the tests relied on hardcoded names of NEGs created by neg-controller in GKE cluster. Now all e2e tests can be run without GKE.
AwesomePatrol
force-pushed
the
fix-tcproute-test
branch
from
cb00cac to
72a3f0f
Compare
|
/approve |
|
/lgtm |
|
/cc @mag-kol |
| {Type: exec.ActionTypeMeta, Name: eventName(negID)}, | ||
| {Type: exec.ActionTypeCreate, Name: actionName(exec.ActionTypeCreate, negID)}, |
There was a problem hiding this comment.
thisis changing the behavior of the test, isn't it?
There was a problem hiding this comment.
yes, previously there were hardcoded references to existing NEGs. Now they are created as needed for the duration of the test
There was a problem hiding this comment.
that's a good point, you don't have to change the behaviour of the test. Just create the NEG with raw API call and leave the node as it was (External).
There was a problem hiding this comment.
I considered that, but I opted for a simpler solution for now. We can always add another test later
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AwesomePatrol, bowei, Ramkumar-K The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
merged commit abfa33a
into
GoogleCloudPlatform:master
Aleksander: Could you PTAL GoogleCloudPlatform#183? Rohit: I’m no longer on this team
Previously, the tests relied on hardcoded names of NEGs created by
neg-controller in GKE cluster. Now all e2e tests can be run without GKE.