Skip to content

Commit

Permalink
Merge pull request #188 from AwesomePatrol/fix-package-confusion
Browse files Browse the repository at this point in the history
Move functions using global test flags to *_test file
  • Loading branch information
google-oss-prow[bot] authored Apr 19, 2024
2 parents cf23c14 + 4224346 commit fafea9f
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 8 deletions.
8 changes: 8 additions & 0 deletions e2e/tcproute_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -432,3 +432,11 @@ func processGraphAndExpectActions(t *testing.T, graphBuilder *rgraph.Builder, ex
t.Logf("exec got Result.Errors len(%d) =\n%v", len(res.Errors), res.Errors)
t.Logf("exec got Result.Pending len(%d) =\n%v", len(res.Pending), res.Pending)
}

func defaultNetworkURL() string {
return cloud.NewNetworksResourceID(testFlags.project, "default").SelfLink(meta.VersionGA)
}

func defaultSubnetworkURL() string {
return cloud.NewSubnetworksResourceID(testFlags.project, region, "default").SelfLink(meta.VersionGA)
}
8 changes: 0 additions & 8 deletions e2e/test-helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,11 +127,3 @@ Outer:
t.Fatalf("Rule ServiceName %s, not found in expected: %v", rule.Action.Destinations[0].ServiceName, svcIds)
}
}

func defaultNetworkURL() string {
return cloud.NewNetworksResourceID(testFlags.project, "default").SelfLink(meta.VersionGA)
}

func defaultSubnetworkURL() string {
return cloud.NewSubnetworksResourceID(testFlags.project, region, "default").SelfLink(meta.VersionGA)
}

0 comments on commit fafea9f

Please sign in to comment.