Merge pull request #173 from kl52752/differ-fix-path

Deep copy path in Differ Results
GoogleCloudPlatform · Mar 5, 2024 · 7926f30 · 7926f30
2 parents b7ec13c + a435cf9
commit 7926f30
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pkg/cloud/api/diff.go b/pkg/cloud/api/diff.go
@@ -62,10 +62,12 @@ type DiffResult struct {
 func (r *DiffResult) HasDiff() bool { return len(r.Items) > 0 }
 
 func (r *DiffResult) add(state DiffItemState, p Path, a, b reflect.Value) {
+
 	di := DiffItem{
 		State: state,
-		Path:  p,
+		Path:  make([]string, len(p)),
 	}
+	copy(di.Path, p)
 	if a.IsValid() {
 		// Interface() will panic if is called on unexported types in this case
 		// the best we can do is to pass its name to the result.