Skip to content

Update pom.xml #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2020
Merged

Update pom.xml #4365

merged 2 commits into from
Dec 8, 2020

Conversation

lesv
Copy link
Contributor

@lesv lesv commented Dec 7, 2020

Latest CRM, needs latest G-A-L-O-H

update

It's a good idea to open an issue first for discussion.

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • API's need to be enabled to test (tell us)
  • Environment Variables need to be set (ask us to set them)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • Please merge this PR for me once it is approved.

Latest CRM, needs latest G-A-L-O-H
@lesv lesv requested a review from a team December 7, 2020 23:18
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 7, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 7, 2020
@lesv
Copy link
Contributor Author

lesv commented Dec 7, 2020

Fixes #4357

reorder dependencies - so the right ones get picked up.
@snippet-bot
Copy link

snippet-bot bot commented Dec 7, 2020

Here is the summary of changes.

You added 1 region tag.
You deleted 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@lesv
Copy link
Contributor Author

lesv commented Dec 8, 2020

Argh - Java 8 works, but not Java 11. Wow.

------------------------------------------------------------
- testing iam/api-client
------------------------------------------------------------
[ERROR] Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 3.554 s <<< FAILURE! - in iam.snippets.QuickstartTests
[ERROR] iam.snippets.QuickstartTests.testQuickstart  Time elapsed: 3.43 s  <<< ERROR!
java.lang.NullPointerException
	at iam.snippets.QuickstartTests.testQuickstart(QuickstartTests.java:138)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2020
@lesv
Copy link
Contributor Author

lesv commented Dec 8, 2020

Trying to run again to see if the problem is just a flaky test.

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 8, 2020
@lesv lesv mentioned this pull request Dec 8, 2020
@lesv lesv merged commit 73a475a into master Dec 8, 2020
@lesv lesv deleted the iam-fix branch December 8, 2020 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants