functions: shrink Kotlin example POM #2846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
i think that block can be removed completely, i can give it a try. |
|
i see why we needed it - the function is written in Kotlin, but test is in Java. We can't default the source/test directory to kotlin. In the mean time, I feel we can remove just the line the rest of the block can remain in tact and do not need to be excluded from the region. |
Move region tags
|
rather than excluding the block, can we remove the line completely? I.e., the line isn't needed at all to compile this code. |
lesv
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@saturnism FYI - hopefully I got everything here?
(The removed section seemed a bit small. 🙂 )