Fix breaking changes on Data Catalog library update#2137
Merged
nnegrey merged 12 commits intoGoogleCloudPlatform:masterfrom Feb 26, 2020
Merged
Fix breaking changes on Data Catalog library update#2137nnegrey merged 12 commits intoGoogleCloudPlatform:masterfrom
nnegrey merged 12 commits intoGoogleCloudPlatform:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
Fix: #2132 |
Contributor
|
@mesmacosta, it seems these tests don't seem to quite finish? Are they just really long running? |
Contributor
Author
|
@nnegrey They are really quick, you have to tag the PR with a label kokoro:run to start the tests on the PR. |
kokoro-team
removed
the
kokoro:run
nnegrey
approved these changes
Feb 26, 2020
kokoro-team
removed
the
kokoro:run
nnegrey
added
automerge
kokoro-team
removed
the
kokoro:force-run
9 tasks
charlieyu1996
pushed a commit
that referenced
this pull request
Nov 11, 2022
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the new Data Catalog library version there was a breaking change on the package naming, to make it clearer what version is being used, hence the tests started failing. Updating the sample codes as requested on the PR: #2102