Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for UrlFetch #1507

Merged
merged 5 commits into from
Jul 10, 2019
Merged

Add flag for UrlFetch #1507

merged 5 commits into from
Jul 10, 2019

Conversation

averikitsch
Copy link
Contributor

No description provided.

@averikitsch averikitsch requested review from lesv and a team July 10, 2019 20:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might wish to explain why you are doing this? So developers understand the choice.
(I'm not sure it's required in this sample)

@@ -2,4 +2,7 @@
<appengine-web-app xmlns="http://appengine.google.com/ns/1.0">
<runtime>java8</runtime>
<threadsafe>true</threadsafe>
<!-- Enable URL Fetch service for networking classes -->
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enable old appengine Java 7 behavior for Networking.

@averikitsch averikitsch merged commit 6990a51 into master Jul 10, 2019
@averikitsch averikitsch deleted the urlfetch branch July 10, 2019 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants