[Cloud Tasks] Add HTTP push queue sample by averikitsch · Pull Request #1355 · GoogleCloudPlatform/java-docs-samples

averikitsch · 2019-03-15T16:49:30Z

No description provided.

…ocs-samples into tasks

averikitsch · 2019-04-15T17:37:51Z

Ping @dzlier-gcp, do you mind reviewing today or tomorrow?

dzlier-gcp · 2019-04-15T18:30:10Z

Taking a look now.

dzlier-gcp · 2019-04-15T18:35:13Z

appengine-java8/tasks/src/main/java/com/example/task/CreateHttpTask.java

+import org.apache.commons.cli.Options;
+import org.apache.commons.cli.ParseException;
+
+public class CreateHttpTask {


Was there a specific directive to make this into a CLI sample instead of the new sample format? If it's just to keep it consistent with the CreateTask sample that already exists here, I don't think that's enough of a reason to do the whole CLI thing instead of following the new template.

This is a quickstart, so It is nice to have the CLI to run it.

Is there an easy way to compile and run if the correct variables are added?

I removed the CLI.

dzlier-gcp · 2019-04-15T21:11:14Z

appengine-java8/tasks/src/main/java/com/example/task/CreateHttpTask.java

+    // Instantiates a client.
+    try (CloudTasksClient client = CloudTasksClient.create()) {
+
+      // Variables provided by the CLI.


by system variables

dzlier-gcp · 2019-04-15T21:12:40Z

appengine-java8/tasks/src/main/java/com/example/task/CreateHttpTask.java

+    String location = System.getenv("LOCATION_ID");
+    String url = System.getenv("URL");
+
+    // [START cloud_tasks_create_http_task]


Please put the START tag above import statements so that the dependency paths are included when the code is hosted on c.g.c. (and move the END tag past close brackets as necessary).

dzlier-gcp · 2019-04-15T21:14:37Z

appengine-java8/tasks/README.md

    --queue $QUEUE_ID --location $LOCATION_ID --payload hello --in-seconds 30"
 ```
+
+### Using HTTP Push Queues


So in line with not having the samples be a CLI, I think we're also not really including run instructions in the README for running the samples from the command line, as these code snippets are really for hosting on c.g.c documentation and not meant to be run directly by the users after cloning the whole repo.

dzlier-gcp · 2019-04-15T21:17:24Z

appengine-java8/tasks/src/main/java/com/example/task/CreateHttpTask.java

+
+public class CreateHttpTask {
+
+  public static void main(String[] args) throws Exception {


Following the new sample template, this wouldn't be a main method, but rather a named one like "createHttpTask", and instead of getting the System env var values below, it would include those 4 things as named parameters. Then there would be commented out declarations of them below, e.g.

public static void createHttpTask(String projectId, String queueName, string location, string url) { // String projectId = "YOUR-PROJECT-ID"; // etc

Then in your test file (unless there's a reason not to include a test with this sample, I don't have full context), you would get those input parameters from required environment variables and supply them in the method call.

This sample will be a part of a quickstart as of right now; therefore I would like to keep the instructions in the README and the main method. I'm adding a bug for myself to update this complete sample after the launch to re-evaluate the CLI in CreateTask.java and add tests.

averikitsch · 2019-04-16T22:57:35Z

In order to be consistent with other languages I moved the HTTP task sample to it's own directory.

averikitsch · 2019-04-17T18:52:42Z

ping @dzlier-gcp (Sorry to bug you again, but trying to get this done by the EOW)

kurtisvg · 2019-04-18T19:33:59Z

tasks/pom.xml

+  <parent>
+    <groupId>com.google.cloud.samples</groupId>
+    <artifactId>shared-configuration</artifactId>
+    <version>1.0.10</version>


Don't forget to update the version of this.

kurtisvg · 2019-04-18T19:34:22Z

tasks/src/main/java/com/example/task/CreateHttpTask.java

+
+    // Instantiates a client.
+    try (CloudTasksClient client = CloudTasksClient.create()) {
+


nix Newline

kurtisvg · 2019-04-18T19:35:52Z

appengine-java8/tasks/README.md

 Create a task, targeted at the `/tasks/create` endpoint, with a payload specified:

 ```
 mvn exec:java -Dexec.mainClass="com.example.task.CreateTask" \


Are these instructions still correct? It looks like you are using environment variables now

This is correct. This readme is associated with the App Engine sample.

…ocs-samples into tasks

* Add HTTP sample * Fix linting * remove CLI * Move http sample * Fix pom.xml * Update pom and linting * Update tasks version

Add HTTP sample

9ce1c96

averikitsch requested review from a team and dzlier-gcp March 15, 2019 16:49

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 15, 2019

averikitsch added 5 commits March 15, 2019 09:54

Merge branch 'master' into tasks

6fcb414

Fix linting

8100299

Merge branch 'tasks' of https://github.com/GoogleCloudPlatform/java-d…

2c674bb

…ocs-samples into tasks

Merge branch 'master' into tasks

0384516

Merge branch 'master' into tasks

4960ec4

dzlier-gcp reviewed Apr 15, 2019

View reviewed changes

remove CLI

cf91602

dzlier-gcp reviewed Apr 15, 2019

View reviewed changes

averikitsch added 2 commits April 16, 2019 15:55

Move http sample

70b0fe6

Fix pom.xml

8e8e534

Merge branch 'master' into tasks

001a0ae

kurtisvg suggested changes Apr 18, 2019

View reviewed changes

averikitsch added 3 commits April 18, 2019 12:50

Update pom and linting

464f710

Merge branch 'tasks' of https://github.com/GoogleCloudPlatform/java-d…

d03f198

…ocs-samples into tasks

Update tasks version

c88de0b

kurtisvg approved these changes Apr 19, 2019

View reviewed changes

averikitsch merged commit df8ea9a into master Apr 19, 2019

averikitsch deleted the tasks branch April 19, 2019 19:20

averikitsch added a commit that referenced this pull request Oct 27, 2022

samples: [Cloud Tasks] Add HTTP push queue sample (#1355)

3a3c045

* Add HTTP sample * Fix linting * remove CLI * Move http sample * Fix pom.xml * Update pom and linting * Update tasks version

averikitsch mentioned this pull request Oct 27, 2022

migrate code from googleapis/java-tasks #7368

Merged

9 tasks

averikitsch added a commit that referenced this pull request Nov 1, 2022

samples: [Cloud Tasks] Add HTTP push queue sample (#1355)

8f0231f

* Add HTTP sample * Fix linting * remove CLI * Move http sample * Fix pom.xml * Update pom and linting * Update tasks version


		public class CreateHttpTask {

		public static void main(String[] args) throws Exception {


		// Instantiates a client.
		try (CloudTasksClient client = CloudTasksClient.create()) {

Conversation

averikitsch commented Mar 15, 2019

Uh oh!

averikitsch commented Apr 15, 2019

Uh oh!

dzlier-gcp commented Apr 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

averikitsch commented Apr 16, 2019

Uh oh!

averikitsch commented Apr 17, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants